[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Sun, Feb 23, 2003 at 03:25:25PM -0800, Jason Short wrote:
> 
> [jdorje - Mon Feb 17 08:08:37 2003]:
> 
> > For some reason square_iterate calls CHECK_MAP_POS on its center tile. 
> > This is a problem since it only shows up in debug mode and is not 
> > obvious to the programmer.  And I really don't know why it does that (I 
> > wrote the code for it, some time ago).
> > 
> > This CHECK_MAP_POS should probably be removed.
> 
> And the patch.

No. No. No. Just because one user has problems with the check you
can't remove it and so punish the other users. Per fixed it in the
correct way in 3484 by fixing this one user.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "A common mistake that people make, when trying to design 
  something completely foolproof is to underestimate the 
  ingenuity of complete fools."
    -- Douglas Adams in Mostly Harmless