Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2003:
[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions
Home

[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions
From: "Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>
Date: Mon, 17 Feb 2003 02:26:42 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Mon, Feb 17, 2003 at 12:08:37AM -0800, Jason Short wrote:
> 
> For some reason square_iterate calls CHECK_MAP_POS on its center tile. 
> This is a problem since it only shows up in debug mode and is not 
> obvious to the programmer.  And I really don't know why it does that (I 
> wrote the code for it, some time ago).
> 
> This CHECK_MAP_POS should probably be removed.

Why? It is a check which tests if the args given to square_iterate are
valid. We have the same checks in other functions/macros likesame_pos.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I was dead ... but I'm better now."
    -- Capitain Sheridan in Babylon 5




[Prev in Thread] Current Thread [Next in Thread]