[Freeciv-Dev] (PR#9799) PATCH: rewrited adjust_map()
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://rt.freeciv.org/Ticket/Display.html?id=9799 >
> [mburda - Tue Aug 31 08:44:50 2004]:
>
> UPDATE
>
> to be commited ;-)
>
> Marcelo
>
Please add some comment here:
+static const int maxval = 1000;
+static int seaval=0, mountainsval =0;
I'd like to see better name for f[] in adjust_hmap
f[i] = (count * maxval) / (map.xsize * map.ysize)
I'm not sure if map.xsize * map.ysize is a real total number of tiles on
a map. Some topology expert should say something about it (That's not me).
Style fixes:
int count=0
should be
int count = 0
INITIALIZE_ARRAY(f,maxval,0);
should be
INITIALIZE_ARRAY(f, maxval, 0);
I like this patch.
Jason had some objections so you have to wait for him.
--
mateusz
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/25
- [Freeciv-Dev] (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/25
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Jason Short, 2004/08/26
- [Freeciv-Dev] (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/27
- [Freeciv-Dev] (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/27
- [Freeciv-Dev] (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/31
- [Freeciv-Dev] (PR#9799) PATCH: rewrited adjust_map(),
Mateusz Stefek <=
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/31
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Jason Short, 2004/08/31
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Jason Short, 2004/08/31
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Jason Short, 2004/08/31
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/31
- [Freeciv-Dev] (PR#9799) PATCH: rewrited adjust_map(), Mateusz Stefek, 2004/08/31
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/31
- [Freeciv-Dev] (PR#9799) PATCH: rewrited adjust_map(), Mateusz Stefek, 2004/08/31
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Marcelo Burda, 2004/08/31
- [Freeciv-Dev] Re: (PR#9799) PATCH: rewrited adjust_map(), Jason Short, 2004/08/31
|
|