Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] (PR#9818) Inland lakes and borders
Home

[Freeciv-Dev] (PR#9818) Inland lakes and borders

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mstefek@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#9818) Inland lakes and borders
From: "Marcelo Burda" <mburda@xxxxxxxxx>
Date: Sat, 28 Aug 2004 03:04:52 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9818 >

> [mstefek - Sam. Aoû. 28 07:47:05 2004]:
> 
> > [jdorje - Fri Aug 27 21:06:12 2004]:
> > 
> > Mateusz Stefek wrote:
> > > <URL: http://rt.freeciv.org/Ticket/Display.html?id=9818 >
> > >
> > > - MAXIMUM_CLAIMED_OCEAN_SIZE (20)
> > > + MAXIMUM_CLAIMED_OCEAN_SIZE (20)
> > 
> > Huh?
> I mean:
> - MAXIMUM_CLAIMED_OCEAN_SIZE (10)
> + MAXIMUM_CLAIMED_OCEAN_SIZE (20)
> 
> Is it ok?
> 
>
but if MAXIMUM_CLAIMED_OCEAN_SIZE == 10 count continents_sourounded is
useless as a lac with 10 tiles, can have only a tiny isle inside, maybe
not a problem to claim it!!

> > > +int ocean_sizes[MAP_NCONT];
> > 
> > Should be static.
> > 
> Patch attached
>  
MAP_NCONT Shuld be renamed has MAX_NUM_CONTINETS
> > Marcelo had a similar patch that counted the sizes (but not
> > boundaries)
> > of both oceans and land continents.  Knowing the size of these will
> > probably be useful at some point.  Is there any advantage to doing the
> > same thing for boundaries (changing lake_surrounders to
> > continent_surrounders)?
> > 
> > jason
> 
> I like my patch more.
me too ;-) i like my patch more :-P
> Adding continent part is an easy task.
but to be done at generator time.
> --
> mateusz
> 
Marcelo


[Prev in Thread] Current Thread [Next in Thread]