Re: [Freeciv-Dev] PATCH: bugfix, select multiple units at city report, code cleanup

[Peter Schaefer <schaefer@xxxxxx>]

David Pfitzner wrote:
> 
> Markus Linnala wrote:
> 
> > I removed white space at the end of the line. And indented
> > files as some parts were not indented as the rest.
> 
> Actually, as a general note, I would prefer if you avoid doing
> that.  It makes the patch longer and thus harder to read to
> find the good stuff.  (Also potentially increased chance of
> patch conflicts, I guess.)
> 

At least, one should use two patches, 
one to fix indentation, and a second patch, the actual one.
Make your actions on cvs transparent to others.
( Speaking from experience as someone who doesn't :-)

Another thing is that it is dangerous to assume
everyone wants to indent like you do;
I guess using selecting the part you want to indent and using
M-x indent-region with a vanilla xemacs(C++-mode, no tabulators) would be best.
-- 
Peter Schaefer - schaefer@xxxxxx, schaefer@xxxxxx