Re: [Freeciv-Dev] PATCH: set_city_shield_bonus

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Tony Stuckey wrote:

> --- citytools.c 1999/05/09 16:25:29     1.40
> +++ citytools.c 1999/05/18 23:32:11
> @@ -475,13 +475,13 @@

  if (city_got_building(pcity, B_FACTORY)) {
    if (city_got_building(pcity, B_MFG))
>        tmp = 100;
>      else
>        tmp = 50;
> -  }

> +    if (city_affected_by_wonder(pcity, B_HOOVER) ||
> +        city_got_building(pcity, B_POWER) ||
> +        city_got_building(pcity, B_HYDRO) ||
> +        city_got_building(pcity,B_NUCLEAR))
> +      tmp *= 1.5;
> +  }

Incidently to really match Civ1 the above would be tmp += 50,
instead of tmp *= 1.5;

That is:
              Current freeciv:   Civ1:
  Factory:               + 50%   + 50%
  Factory + Mfg:         +100%   +100%
  Factory + Power:       + 75%   +100%  <-- difference
  Factory + Mfg + Power: +150%   +150%

Can anyone check Civ2?

(This would also want changes to helpdata.txt)

-- David