[Freeciv-Dev] Re: (PR#12757) Move some govt stuff to effects

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12757 >

On Sun, 10 Apr 2005, Jason Short wrote:
> IMO this patch is too big to be wieldy. Each new effect type needs
> close inspection

These are not 'new' game mechanics, just porting of existing mechanics
from govt ruleset to effects.

> and we need to update all the other rulesets too.

Anticipating objections, I did not want to do more work than I had to. I
will update the other rulesets once the patch is set to go in.

> If possible it would be better to do this with one patch per effect
> type.

No point in that. Way too much work.

> Also if we are to clean up the effects.ruleset (for instance, by
> allowing effects declarations in other rulesets, so effects and sources
> may be placed close to each other) we might want to do that first.

Depends on when you intend to do this. As you noted, it is a big patch,
and I would hate to see it stall and bitrot. This is just a first step,
and the next steps will not be taken until this is in cvs.

  - Per