[Freeciv-Dev] Re: (PR#6933) Don't skip the iterate_end macros

["email_address=jdorje@xxxxxxxxxxx" <email_address=jdorje@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=6933 >

>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=6933 >
>
> Raimar Falke wrote:
>>
>> If the body of the iterate however contains a goto or return statement
>> the _iterate_end macro isn't executed and the counter is wrong. The
>> idea here is to forbid such behavior.
>>
>> The attached script tries to find such places. Run it like
>>  $ find . -name "*.c" | xargs -n 1 python balanced_iterate.py
>
>   This script looks like a good candidate for 'make src-check'.
>
>   Sadly, it finds more problems than it did a year ago:
> bash-2.05b$ find freeciv -name "*.c" | xargs -n 1 python
> patches/balanced_iterate.py | wc -l
>      125

I kindof thought we'd given up on that idea.  Per's recent genlist patches
have used garbage collection instead.

-jason