[Freeciv-Dev] (PR#6502) uninitialized data sent server->client

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

In the server:

==20272== Syscall param write(buf) contains uninitialised or 
unaddressable byte(s)
==20272==    at 0x40455238: __GI___libc_write (in /lib/libc-2.3.2.so)
==20272==    by 0x80A89BF: write_socket_data (connection.c:200)
==20272==    by 0x80A8A91: flush_connection_send_buffer_all 
(connection.c:236)
==20272==    by 0x80A8D4A: connection_do_unbuffer (connection.c:356)
==20272==    by 0x809CC47: sniff_packets (sernet.c:612)
==20272==    by 0x804FAAC: main_loop (srv_main.c:1480)
==20272==    by 0x80503E4: srv_loop (srv_main.c:1812)
==20272==    by 0x804FE68: srv_main (srv_main.c:1599)
==20272==    by 0x804A27B: main (civserver.c:154)
==20272==    by 0x403A04EC: __libc_start_main (in /lib/libc-2.3.2.so)
==20272==    by 0x8049C60: (within /tmp/jshort/freeciv/server/civserver)
==20272==    Address 0x41509EBE is 218 bytes inside a block of size 
40960 alloc'd
==20272==    at 0x40160749: malloc (vg_clientfuncs.c:103)
==20272==    by 0x804AC33: fc_real_malloc (mem.c:58)
==20272==    by 0x80A8FBA: new_socket_packet_buffer (connection.c:445)
==20272==    by 0x809CEF8: server_accept_connection (sernet.c:732)
==20272==    by 0x809CAB9: sniff_packets (sernet.c:530)
==20272==    by 0x804FF44: srv_loop (srv_main.c:1637)
==20272==    by 0x804FE68: srv_main (srv_main.c:1599)
==20272==    by 0x804A27B: main (civserver.c:154)
==20272==    by 0x403A04EC: __libc_start_main (in /lib/libc-2.3.2.so)
==20272==    by 0x8049C60: (within /tmp/jshort/freeciv/server/civserver)

this is not a very helpful backtrace, but shows that some packets still 
send uninitialized data.

Savegame attached; I dunno if it's reproducable.

jason

game.sav.bz2
Description: game.sav.bz2