[Freeciv-Dev] Re: [PATCH] advdomestic.c cleanup (PR#1149)

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Fri, Dec 21, 2001 at 05:08:29PM CET, I got a letter,
where Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> told me, that...
>  --- Petr Baudis <pasky@xxxxxxxxxxx> wrote: 
> > Dear diary, on Thu, Dec 20, 2001 at 03:56:35PM CET, I got a letter,
> [...]
> > > > +  /* Usage of (happy && bored) led to a lack of foresight,
> > especially
> > > > +   * re: Chapel -- Syela */
> > > > +  while (happy) { happy--; happy += SADVAL; }
> > >                              ^^^^^^^^
> > > surely you mean value here ;)
> > Ouch. I don't get it, but my autogame tests just *didn't* catch that. 
> 
> this is suspicious.
> maybe try and put assert(!happy) here?
We shouldn't. It's not a requirement. When (!happy), you just actually drained
whole effect of the building.

> > And funny that even both Raahul and Ross didn't notice it as well.
> 
> pah I am just so much better reviewer ;)
*g*

> > > In general the patch is very good and I can only pity it's sad fate.
> > Ehm? What? Sad fate?! ;)
> > 
> 
> I have a bad premonition about your patch...
I want to get it into official CVS and if it will be possible I hope I will get
it there :). I just don't see anything controversial on it (hey, I even try to
abide coding rules), I see sufficient (for me) feedback for it, so what? 

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv hacking
.
  "A common mistake that people make, when trying to design
   something completely foolproof is to underestimate the
   ingenuity of complete fools."
     -- Douglas Adams in Mostly Harmless
.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/