Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: semi-quick tile_is_known patch
Home

[Freeciv-Dev] Re: semi-quick tile_is_known patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>
Cc: Freeciv-Dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: semi-quick tile_is_known patch
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 28 Oct 2001 17:53:09 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sat, Oct 27, 2001 at 12:20:39AM -0500, Mike Kaufman wrote:
> attached is a patch to move tile_is_known() from map.c to climisc.c
> is does this plus add appropriate includes in two files and change a
> ptile->known to the function call in mapctrl.c
> 

> one caveat: the macro MAP_TILE in the body of tile_is_known() has been
> removed. This is because MAP_TILE is defined in map.c rather than map.h
> I did not want to move it until I got feedback from the list. yes, this
> kind of direct access to map.tiles is not good. So respond with a
> suggestion.

There should be no use of MAP_TILE or map_inx outside of map.[ch]. Use
map_get_tile()->known instead.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Two OS engineers facing a petri net chart:
        "dead lock in four moves!"


[Prev in Thread] Current Thread [Next in Thread]