[Freeciv-Dev] Re: [Update] game_info packet fix

[David Pfitzner <dwpfitzner@xxxxxxxxx>]

Mike Jing <miky40@xxxxxxxxxxx> wrote: 

> This small patch adds precviously missing handling for unhappysize and 
> cityfactor in the game_info packet, so that they are properly updated in the 
> client.
> 
> The reason for this small patch is that, although "unhappysize" and
> "cityfactor" are defined in the game_info packet, they are never properly 
> updated on the client side because they are not included in the packet 
> handling routines.  Since I would like to display happiness related info in 
> the Happiness display, I would need the correct value for these two 
> parameters.  So I simply added the missing lines in the packet handling 
> routines.
> 
> Note: this does *NOT* change the protocol because those two variables were 
> already in the packet, but simply weren't given any value.

Its a protocol change in the sense that if your client starts making
use of these values, it matters alot whether the server is pre-patch
or post-patch.

I'm wondering why you actually want these values anyway?  I would have 
thought the Happiness display would display values calculated in the 
server and communicated to the client, whereas if you want these values 
it suggests you're putting duplicate calculations in the client?

-- David

__________________________________________________
Do You Yahoo!?
Get personalized email addresses from Yahoo! Mail - only $35 
a year!  http://personal.mail.yahoo.com/